WIP: Drop --tags from git describe#97
Open
agx wants to merge 2 commits intonxp-imx:masterfrom
Open
Conversation
This is not needed when using annotated tags.
nxpfrankli
force-pushed
the
master
branch
19 times, most recently
from
1597a12 to
0f8362f
Compare
nxpfrankli
force-pushed
the
master
branch
5 times, most recently
from
1d35ccf to
786f133
Compare
nxpfrankli
force-pushed
the
master
branch
5 times, most recently
from
629d224 to
8925b6c
Compare
nxpfrankli
force-pushed
the
master
branch
7 times, most recently
from
e55c395 to
42f13af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #96 applied we can drop
--tagsfrom describe making suregit describeonly picks up annotated tags. This allows e.g. users hacking on uuu to use lightweight tags in their working copy without tripping upuuu_get_version().This should be appplied after #96 and after at least one annotated tag was created. I will rebase this commit if/once #96 is applied.